[ 
https://issues.apache.org/jira/browse/HADOOP-8985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485625#comment-13485625
 ] 

Hudson commented on HADOOP-8985:
--------------------------------

Integrated in Hadoop-Mapreduce-trunk #1239 (See 
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1239/])
    HADOOP-8985. Add namespace declarations in .proto files for languages other 
than java. Thank you Binglin Chan. (Revision 1402845)

     Result = FAILURE
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1402845
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* 
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto/HAServiceProtocol.proto
* 
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto/IpcConnectionContext.proto
* 
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto/ProtocolInfo.proto
* 
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto/RpcPayloadHeader.proto
* 
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto/ZKFCProtocol.proto
* 
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto/hadoop_rpc.proto
* 
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/proto/test.proto
* 
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/proto/test_rpc_service.proto

                
> Add namespace declarations in .proto files for languages other than java
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-8985
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8985
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ha, ipc
>    Affects Versions: 2.0.2-alpha
>            Reporter: Binglin Chang
>            Assignee: Binglin Chang
>            Priority: Minor
>             Fix For: 3.0.0, 2.0.3-alpha
>
>         Attachments: HADOOP-8985-add-namespace.patch
>
>
> Currently .proto files use java_package to specify java packages in proto 
> files, but namespace are not specified for other languages such as cpp, this 
> causes name collision in cpp. we can add namespace declarations to avoid 
> this. 
> In Java, the package specifier is used as the Java package, unless you 
> explicitly provide a option java_package in your .proto file. So the original 
> java package will not be affected.
> About namespace name, how about "hadoop.common"(hadoop::common in cpp) for 
> all common sub-project proto files, and "hadoop.hdfs"(hadoop::hdfs in cpp) 
> for all hdfs sub-project proto files?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to