[ 
https://issues.apache.org/jira/browse/HADOOP-8956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Nauroth updated HADOOP-8956:
----------------------------------

    Attachment: HADOOP-8956-branch-trunk-win.patch

Thanks, Brandon.  I've uploaded a new patch with the following changes based on 
your feedback:

# I added comments to the regex to help clarify.  I tried that regex that you 
mentioned, but unfortunately it didn't actually work.  :-)
# I changed the method name to isTestableFileNameOnPlatform to indicate that 
it's not a full validity check, but just a sufficient check to see if the test 
should proceed.
# I added comments to isTestableFileNameOnPlatform specifically explaining that 
the current implementation filters out file names that aren't compatible with 
Windows.

How does this look?

                
> FileSystem.primitiveMkdir failures on Windows cause multiple test suites to 
> fail
> --------------------------------------------------------------------------------
>
>                 Key: HADOOP-8956
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8956
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>    Affects Versions: trunk-win
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>         Attachments: HADOOP-8956-branch-trunk-win.patch, 
> HADOOP-8956-branch-trunk-win.patch, HADOOP-8956-branch-trunk-win.patch
>
>
> Multiple test suites fail on Windows in calls to FileSystem.primitiveMkdir.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to