[
https://issues.apache.org/jira/browse/HADOOP-9046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13506447#comment-13506447
]
Ivan A. Veselovsky commented on HADOOP-9046:
--------------------------------------------
Hi, Robert, thanks for the comments.
1. Created separate Jira https://issues.apache.org/jira/browse/HADOOP-9104 .
The TODO comment is removed.
2. Renamed: lock0 -> queueLock, available0 -> queueContentChangedCondition.
3. The token cancellation upon removal was introduced in HADOOP-9084, and it
appeared to be acsidently overwritten by my changes. I returned those changes
back and also added relevant checking to the test. Thanks for this catch.
4. I fixed the problem using java.lang.Thread.getState() method: now, first, we
start the thread if needed, and, 2nd, we check if it already died.
If the thread is dead, we throw IllegalStateException.
This way (1) the thread never attempts to start twice, and (2) any attempt to
add an action to the dead thread is rejected.
I also added into the test the check to verify that this really the case.
The described changes are in patches "xxx--d.patch".
> provide unit-test coverage of class
> org.apache.hadoop.fs.DelegationTokenRenewer.RenewAction<T>
> ----------------------------------------------------------------------------------------------
>
> Key: HADOOP-9046
> URL: https://issues.apache.org/jira/browse/HADOOP-9046
> Project: Hadoop Common
> Issue Type: Test
> Affects Versions: 3.0.0, 2.0.3-alpha, 0.23.6
> Reporter: Ivan A. Veselovsky
> Assignee: Ivan A. Veselovsky
> Priority: Minor
> Attachments: HADOOP-9046-branch-0.23--c.patch,
> HADOOP-9046-branch-0.23-over-9049.patch, HADOOP-9046-branch-0.23.patch,
> HADOOP-9046--c.patch, HADOOP-9046--d.patch, HADOOP-9046-over-9049.patch,
> HADOOP-9046.patch
>
>
> The class org.apache.hadoop.fs.DelegationTokenRenewer.RenewAction<T> has zero
> coverage in entire cumulative test run. Provide test(s) to cover this class.
> Note: the request submitted to HDFS project because the class likely to be
> tested by tests in that project.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
