[
https://issues.apache.org/jira/browse/HADOOP-9090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13507744#comment-13507744
]
Luke Lu commented on HADOOP-9090:
---------------------------------
Why don't you just make WaitableMetricsBuffer extends MetricsBuffer? like this:
{code}
static WaitableMetricsBuffer extends MetricsBuffer {
WaitableMetricsBuffer(MetricsBuffer buffer) {
super(buffer);
}
...
}
{code}
Less change to existing code...
> Support on-demand publish of metrics
> ------------------------------------
>
> Key: HADOOP-9090
> URL: https://issues.apache.org/jira/browse/HADOOP-9090
> Project: Hadoop Common
> Issue Type: New Feature
> Components: metrics
> Reporter: Mostafa Elhemali
> Priority: Minor
> Attachments: HADOOP-9090.2.patch,
> HADOOP-9090.justEnhanceDefaultImpl.2.patch,
> HADOOP-9090.justEnhanceDefaultImpl.3.patch,
> HADOOP-9090.justEnhanceDefaultImpl.4.patch,
> HADOOP-9090.justEnhanceDefaultImpl.5.patch,
> HADOOP-9090.justEnhanceDefaultImpl.6.patch,
> HADOOP-9090.justEnhanceDefaultImpl.7.patch,
> HADOOP-9090.justEnhanceDefaultImpl.patch, HADOOP-9090.patch
>
>
> Updated description based on feedback:
> We have a need to publish metrics out of some short-living processes, which
> is not really well-suited to the current metrics system implementation which
> periodically publishes metrics asynchronously (a behavior that works great
> for long-living processes). Of course I could write my own metrics system,
> but it seems like such a waste to rewrite all the awesome code currently in
> the MetricsSystemImpl and supporting classes.
> The way this JIRA solves this problem is adding a new method
> publishMetricsNow() to the MetricsSystemImpl() class, that does a synchronous
> out-of-band push of the metrics from the sources to the sink. I also add a
> method to MetricsSinkAdapter (putMetricsImmediate) to support that change.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
