[
https://issues.apache.org/jira/browse/HADOOP-9117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13510660#comment-13510660
]
Colin Patrick McCabe commented on HADOOP-9117:
----------------------------------------------
This looks good. It's in Java, so all Hadoop programmers should be able to
understand it. It also will benefit the wider community of Maven users, not
just our project.
I took a quick look at the linked repo. Overall, the code is very good. In
{{VersionInfoMojo.java:determineSCM}}, it seems like there's a bit of
unnecessary if nesting. Perhaps it would be better to just return the SCM that
you have determined immediately, and add the log message in the caller?
> replace protoc ant plugin exec with a maven plugin
> --------------------------------------------------
>
> Key: HADOOP-9117
> URL: https://issues.apache.org/jira/browse/HADOOP-9117
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 2.0.2-alpha
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Attachments: HADOOP-9117.patch
>
>
> The protoc compiler is currently invoked using ant plugin exec. There is a
> bug in the ant plugin exec task which does not consume the STDOUT or STDERR
> appropriately making the build to stop sometimes (you need to press enter to
> continue).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
