[ https://issues.apache.org/jira/browse/HADOOP-9113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13512011#comment-13512011 ]
Eli Collins commented on HADOOP-9113: ------------------------------------- lgtm Nit: the two assertTrues should be assertEquals so you can see what the value actually was if the test fails > o.a.h.fs.TestDelegationTokenRenewer is failing intermittently > ------------------------------------------------------------- > > Key: HADOOP-9113 > URL: https://issues.apache.org/jira/browse/HADOOP-9113 > Project: Hadoop Common > Issue Type: Bug > Components: security, test > Affects Versions: 2.0.2-alpha > Reporter: Karthik Kambatla > Assignee: Karthik Kambatla > Fix For: 2.0.3-alpha > > Attachments: hadoop-9113.patch, hadoop-9113.patch, hadoop-9113.patch > > > In the following code snippets, the test tries to check the renewCount for > the token to verify if the FileSystem has been de-queued. > {code} > @Override > public long renew(Configuration conf) { > if (renewCount == MAX_RENEWALS) { > Thread.currentThread().interrupt(); > } else { > renewCount++; > } > return renewCount; > } > testAddRemoveRenewAction() { > // some test code > assertTrue("Token not removed", (tfs.testToken.renewCount < MAX_RENEWALS)); > } > {code} > On slower machines, the renewCount can actually reach MAX_RENEWALS resulting > in a test failure. > renewCount should not be used to verify this. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira