[
https://issues.apache.org/jira/browse/HADOOP-9018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13528227#comment-13528227
]
Ivan Mitic commented on HADOOP-9018:
------------------------------------
Thanks Arpit, change looks good! I have some mainly minor comments:
1. Can you please summarize in a Jira the behaviors that this patch tries to
enforce? Which paths are allowed and which are not?
2. Path.java:53
- hasDriveLetterSpecifier, can you add a comment explaining why a scheme "/c:"
is valid.
3. Path.java:203: I assume we should use string compare instead of {{scheme ==
""}} and {{(scheme == "file"}. Btw, why is this needed?
4. PathData.java: Can we rename the inferredSchemeFromPath variable to better
reflect the current usage?
5. I would recommend running all unittests before committing. The change could
introduce regressions.
6. TestPath and TestPathData: Would it make sense to add test cases for invalid
relative paths?
7. Is the issue mentioned in HADOOP-8139 fixed with this change?
> Reject invalid Windows URIs
> ---------------------------
>
> Key: HADOOP-9018
> URL: https://issues.apache.org/jira/browse/HADOOP-9018
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
> Affects Versions: trunk-win
> Environment: Windows
> Reporter: Arpit Agarwal
> Assignee: Arpit Agarwal
> Attachments: HADOOP-9018.1.patch, HADOOP-9018.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> This JIRA is to make handling of improperly constructed file URIs for Windows
> local paths more rigorous. e.g. reject "file:///c:\\Windows"
> Valid file URI syntax explained at
> http://blogs.msdn.com/b/ie/archive/2006/12/06/file-uris-in-windows.aspx.
> Also see https://issues.apache.org/jira/browse/HADOOP-8953
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
