[
https://issues.apache.org/jira/browse/HADOOP-8957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Nauroth updated HADOOP-8957:
----------------------------------
Attachment: HADOOP-8957-branch-trunk-win.3.patch
Thank you, Sanjay. I have uploaded version 3 of the patch to address the
latest feedback. I changed {{RawLocalFs#isValidName}} so that it only returns
true on Windows and otherwise calls the base class. I updated the JavaDoc on
{{AbstractFileSystem#isValidName}}.
{quote}
Looks like RawLocalFileSystem is not checking for ":" in path. Should it be?
{quote}
This reminds me why I originally chose to return true from
{{RawLocalFs#isValidName}}. Since {{RawLocalFileSystem}} doesn't enforce this,
and since it is older than {{RawLocalFs}}, it made me wonder if {{RawLocalFs}}
was actually incorrect to enforce this validation. It means that some file
names that could be supported on the local file system will get rejected.
{{RawLocalFileSystem}} doesn't have this limitation.
Still, it's more conservative to add the if (WINDOWS) check like you suggested
and preserve the current behavior of {{RawLocalFs}} on non-Windows. We can
always remove the if (WINDOWS) check later if we decide we want to change the
behavior.
> AbstractFileSystem#IsValidName should be overridden for embedded file systems
> like ViewFs
> -----------------------------------------------------------------------------------------
>
> Key: HADOOP-8957
> URL: https://issues.apache.org/jira/browse/HADOOP-8957
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: trunk-win
> Reporter: Chris Nauroth
> Assignee: Chris Nauroth
> Attachments: HADOOP-8957-branch-trunk-win.2.patch,
> HADOOP-8957-branch-trunk-win.3.patch, HADOOP-8957.patch, HADOOP-8957.patch
>
>
> This appears to be a problem with parsing a Windows-specific path, ultimately
> throwing InvocationTargetException from AbstractFileSystem.newInstance.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
