[
https://issues.apache.org/jira/browse/HADOOP-8698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13531896#comment-13531896
]
Hadoop QA commented on HADOOP-8698:
-----------------------------------
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12560868/setconf-null4.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/1868//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/1868//console
This message is automatically generated.
> Do not call unneceseary setConf(null) in Configured constructor
> ---------------------------------------------------------------
>
> Key: HADOOP-8698
> URL: https://issues.apache.org/jira/browse/HADOOP-8698
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.3, 3.0.0
> Reporter: Radim Kolar
> Assignee: Radim Kolar
> Priority: Minor
> Fix For: 0.24.0, 3.0.0
>
> Attachments: setconf-null2.txt, setconf-null3.txt, setconf-null4.txt,
> setconf-null.txt
>
>
> no-arg constructor of /org/apache/hadoop/conf/Configured calls setConf(null).
> This is unnecessary and it increases complexity of setConf() code because you
> have to check for not null object reference before using it. Under normal
> conditions setConf() is never called with null reference, so not null check
> is unnecessary.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
