[ 
https://issues.apache.org/jira/browse/HADOOP-9144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13532792#comment-13532792
 ] 

Chris Nauroth commented on HADOOP-9144:
---------------------------------------

To clarify, this patch fixes these 2 FindBugs warnings:

Comparison of String parameter using == or != in 
org.apache.hadoop.fs.Path.normalizePath(String, String)
Bug type ES_COMPARING_PARAMETER_STRING_WITH_EQ (click for details) 
In class org.apache.hadoop.fs.Path
In method org.apache.hadoop.fs.Path.normalizePath(String, String)
Actual type String
At Path.java:[line 202]

org.apache.hadoop.fs.FileUtil.setPermission(File, FsPermission) ignores 
exceptional return value of java.io.File.setWritable(boolean, boolean)
Bug type RV_RETURN_VALUE_IGNORED_BAD_PRACTICE (click for details) 
In class org.apache.hadoop.fs.FileUtil
In method org.apache.hadoop.fs.FileUtil.setPermission(File, FsPermission)
Called method java.io.File.setWritable(boolean, boolean)
At FileUtil.java:[line 705]

                
> FindBugs reports new warnings in branch-trunk-win
> -------------------------------------------------
>
>                 Key: HADOOP-9144
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9144
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>    Affects Versions: trunk-win
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>         Attachments: HADOOP-9144-branch-trunk-win.1.patch
>
>
> Testing the merge from branch-trunk-win to trunk, we saw some new FindBugs 
> warnings that need to be fixed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to