[
https://issues.apache.org/jira/browse/HADOOP-9155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13538180#comment-13538180
]
Hadoop QA commented on HADOOP-9155:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12562091/HADOOP-9155.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-common-project/hadoop-common:
org.apache.hadoop.fs.TestFileStatus
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/1918//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/1918//console
This message is automatically generated.
> FsPermission should have different default value, 777 for directory and 666
> for file
> ------------------------------------------------------------------------------------
>
> Key: HADOOP-9155
> URL: https://issues.apache.org/jira/browse/HADOOP-9155
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 3.0.0, 2.0.3-alpha
> Reporter: Binglin Chang
> Assignee: Binglin Chang
> Priority: Minor
> Attachments: HADOOP-9155.patch
>
>
> The default permission for {{FileSystem#create}} is the same default as for
> {{FileSystem#mkdirs}}, namely {{0777}}. It would make more sense for the
> default to be {{0666}} for files and {{0777}} for directories. The current
> default leads to a lot of files being created with the executable bit that
> really should not be. One example is anything created with FsShell's
> copyToLocal.
> For reference, {{fopen}} creates files with a mode of {{0666}} (minus
> whatever bits are set in the umask; usually {{0022}}. This seems to be the
> standard behavior and we should follow it. This is also a regression since
> branch-1.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
