[ 
https://issues.apache.org/jira/browse/HADOOP-9174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arpit Agarwal updated HADOOP-9174:
----------------------------------

    Description: 
TestSecurityUtil.TestBuildTokenServiceSockAddr fails due to implicit dependency 
on the test case execution order.

Testcase: testBuildTokenServiceSockAddr took 0.003 sec
        Caused an ERROR
expected:<[127.0.0.1]:123> but was:<[localhost]:123>
        at 
org.apache.hadoop.security.TestSecurityUtil.testBuildTokenServiceSockAddr(TestSecurityUtil.java:133)


Similar bug exists in TestSecurityUtil.testBuildDTServiceName.

The root cause is that a helper routine (verifyAddress) used by some test cases 
has a side effect. It resets a static variable 
(SecurityUtil.useIpForTokenService). 

The broken test cases assume that the flag will be set to true when they are 
invoked. The fix is to explicitly initialize the flag to its expected value 
instead of depending on the execution order.

  was:
TestSecurityUtil.TestBuildTokenServiceSockAddr fails due to implicit dependency 
on the test case execution order.

Testcase: testBuildTokenServiceSockAddr took 0.003 sec
        Caused an ERROR
expected:<[127.0.0.1]:123> but was:<[localhost]:123>
        at 
org.apache.hadoop.security.TestSecurityUtil.testBuildTokenServiceSockAddr(TestSecurityUtil.java:133)


Similar bug exists in TestSecurityUtil.testBuildDTServiceName.

    
> TestSecurityUtil failure on Windows with Open JDK 7
> ---------------------------------------------------
>
>                 Key: HADOOP-9174
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9174
>             Project: Hadoop Common
>          Issue Type: Test
>    Affects Versions: 1-win
>            Reporter: Arpit Agarwal
>            Assignee: Arpit Agarwal
>         Attachments: HADOOP-9174.patch
>
>
> TestSecurityUtil.TestBuildTokenServiceSockAddr fails due to implicit 
> dependency on the test case execution order.
> Testcase: testBuildTokenServiceSockAddr took 0.003 sec
>       Caused an ERROR
> expected:<[127.0.0.1]:123> but was:<[localhost]:123>
>       at 
> org.apache.hadoop.security.TestSecurityUtil.testBuildTokenServiceSockAddr(TestSecurityUtil.java:133)
> Similar bug exists in TestSecurityUtil.testBuildDTServiceName.
> The root cause is that a helper routine (verifyAddress) used by some test 
> cases has a side effect. It resets a static variable 
> (SecurityUtil.useIpForTokenService). 
> The broken test cases assume that the flag will be set to true when they are 
> invoked. The fix is to explicitly initialize the flag to its expected value 
> instead of depending on the execution order.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to