[
https://issues.apache.org/jira/browse/HADOOP-9097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13551220#comment-13551220
]
Tom White commented on HADOOP-9097:
-----------------------------------
Regarding the source files with third party licenses, by my reading of
http://apache.org/legal/resolved.html#required-third-party-notices and the
licenses in hadoop-hdfs-project/hadoop-hdfs/src/main/native/util/tree.h and
hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/io/compress/lz4/lz4.c,
it is necessary to add the licenses to the Hadoop LICENSE.txt files. I see
that lz4.c's license is in the common LICENSE.txt file, but tree.h isn't in
HDFS's. So that should be fixed.
I notice that the following files are empty and can presumably be removed:
*
hadoop-hdfs-project/hadoop-hdfs/src/test/aop/org/apache/hadoop/hdfs/server/datanode/DataXceiverAspects.aj
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolProtocolBuffers/overview.html
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/MockApp.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/MockContainer.java
Though not strictly necessary, it would be nice to add .git/** and .idea/** to
the top-level excludes.
With these changes I managed to get a clean run of {{mvn apache-rat:check}}
with the combined patch.
+1 on the combined patch. Thanks a lot for doing this work Tom.
> Maven RAT plugin is not checking all source files
> -------------------------------------------------
>
> Key: HADOOP-9097
> URL: https://issues.apache.org/jira/browse/HADOOP-9097
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 2.0.3-alpha, 0.23.5
> Reporter: Tom White
> Assignee: Thomas Graves
> Priority: Critical
> Fix For: 2.0.3-alpha, 0.23.6
>
> Attachments: HADOOP-9097-branch-0.23-entire.patch,
> HADOOP-9097-branch-0.23.patch, HADOOP-9097-entire.patch, HADOOP-9097.patch,
> HADOOP-9097-remove-branch23.sh, HADOOP-9097-remove-branch2.sh,
> HADOOP-9097-remove-entire.sh
>
>
> Running 'mvn apache-rat:check' passes, but running RAT by hand (by
> downloading the JAR) produces some warnings for Java files, amongst others.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
