[ 
https://issues.apache.org/jira/browse/HADOOP-9196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13556666#comment-13556666
 ] 

James commented on HADOOP-9196:
-------------------------------

I ran some benchmarks and it appears that calling read for each byte is ~2x 
slower than the current implementation.  

I re-ran the tests using a 4096 byte[] in {{write()}} (instead of the full 
{{getNBytes()}}) and that was only ~%10 slower than the current implementation. 
 So, that may be an acceptable space/time trade-off.
                
> Modify BloomFilter read() and write() to address memory concerns
> ----------------------------------------------------------------
>
>                 Key: HADOOP-9196
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9196
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: James
>            Priority: Minor
>
> It appears that org.apache.hadoop.util.bloom.BloomFilter's write() method 
> creates a byte array large enough to fit the entire bit vector into memory 
> during serialization.  This is unnecessary and may cause out of memory issues 
> if the bit vector is sufficiently large and memory is tight.   

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to