[ 
https://issues.apache.org/jira/browse/HADOOP-9225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13557540#comment-13557540
 ] 

Colin Patrick McCabe commented on HADOOP-9225:
----------------------------------------------

Hi Vadim,

Thanks for writing this test.  We can always use more testing.

{code}
+  private static boolean isNativeSnappyLoadable() {
+    try {
+      boolean loaded = SnappyDecompressor.isNativeCodeLoaded();
+      return loaded;
+    } catch (Throwable t) {
+      log.warn("Failed to load snappy: ", t);
+      return false;
+    }
+  }
{code}

Is this needed, given that you have this code earlier?

{code}
+  @Before
+  public void before() {
+    assumeTrue(NativeCodeLoader.isNativeCodeLoaded()
+        && NativeCodeLoader.buildSupportsSnappy());
...
{code}
                
> Cover package org.apache.hadoop.compress.Snappy
> -----------------------------------------------
>
>                 Key: HADOOP-9225
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9225
>             Project: Hadoop Common
>          Issue Type: Test
>    Affects Versions: 3.0.0, 2.0.3-alpha, 0.23.6
>            Reporter: Vadim Bondarev
>         Attachments: HADOOP-9225-branch-0.23-a.patch, 
> HADOOP-9225-branch-2-a.patch, HADOOP-9225-trunk-a.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to