[ 
https://issues.apache.org/jira/browse/HADOOP-8857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13562265#comment-13562265
 ] 

Hadoop QA commented on HADOOP-8857:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12566424/HADOOP-8857.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-common-project/hadoop-common.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/2090//testReport/
Console output: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/2090//console

This message is automatically generated.
                
> hadoop.http.authentication.signature.secret.file docs should not state that 
> secret is randomly generated
> --------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-8857
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8857
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 2.0.0-alpha
>            Reporter: Eli Collins
>            Assignee: Owen O'Malley
>            Priority: Minor
>         Attachments: HADOOP-8857.patch
>
>
> The docs and default.xml state that the secret is randomly generated if the 
> secret.file is not present, this is incorrect as the secret must be shared 
> across all nodes in the cluster as it is used to verify the signature of the 
> hadoop.auth cookie. If randomly generated it would be diff in all nodes.
> ORIGINAL DESCRIPTION:
> AuthenticationFilterInitializer#initFilter fails if the configured 
> {{hadoop.http.authentication.signature.secret.file}} does not exist, eg:
> {noformat}
> java.lang.RuntimeException: Could not read HTTP signature secret file: 
> /var/lib/hadoop-hdfs/hadoop-http-auth-signature-secret
> {noformat}
> Creating /var/lib/hadoop-hdfs/hadoop-http-auth-signature-secret (populated 
> with a string) fixes the issue. Per the auth docs "If a secret is not 
> provided a random secret is generated at start up time.", which sounds like 
> it means the file should be generated at startup with a random secrete, which 
> doesn't seem to be the case. Also the instructions in the docs should be more 
> clear in this regard.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to