[ 
https://issues.apache.org/jira/browse/HADOOP-9246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Nauroth updated HADOOP-9246:
----------------------------------

    Attachment: HADOOP-9246.2.patch

FYI, the HADOOP-9245 patch caused the built version info properties files to be 
incorrect.  Running in the compile phase populated the version info properties 
too late, and then the filtering left tokens unreplaced like 
${version-info.build.time}.  Sorry for not catching this during my code review 
of HADOOP-9245.

Ultimately, this caused a test failure in YARN's {{TestNMWebServices}} while 
trying to parse the date returned from the web service.  I retested this with 
hadoop-9246.patch, which was binding to the prepare-resources phase, but it 
didn't fix the problem.

I'm uploading HADOOP-9246.2.patch, which binds to the generate-resources phase, 
which runs before resource filtering.  Once I did this, the version info 
properties files were populated correctly, and {{TestNMWebServices}} passed.  
I've also removed the defaultPhase from the mojo annotation.

                
> Execution phase for hadoop-maven-plugin should be process-resources
> -------------------------------------------------------------------
>
>                 Key: HADOOP-9246
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9246
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 3.0.0, trunk-win
>            Reporter: Karthik Kambatla
>            Assignee: Karthik Kambatla
>         Attachments: HADOOP-9246.2.patch, hadoop-9246.patch, hadoop-9246.patch
>
>
> Per discussion on HADOOP-9245, the execution phase of hadoop-maven-plugin 
> should be _process-resources_ and not _compile_.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to