[
https://issues.apache.org/jira/browse/HADOOP-9259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13564747#comment-13564747
]
Hadoop QA commented on HADOOP-9259:
-----------------------------------
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12565109/HDFS-4409.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/2107//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/2107//console
This message is automatically generated.
> FileSystemContractBaseTest should be less brittle in teardown
> -------------------------------------------------------------
>
> Key: HADOOP-9259
> URL: https://issues.apache.org/jira/browse/HADOOP-9259
> Project: Hadoop Common
> Issue Type: Improvement
> Components: test
> Affects Versions: 3.0.0, 1.1.2
> Reporter: Steve Loughran
> Priority: Minor
> Attachments: HDFS-4409.patch
>
>
> the teardown code in FileSystemContractBaseTest assumes that {{fs!=null}} and
> that it's OK to throw an exception if the delete operation fails. Better to
> check the {{fs}} value and catch and convert an exception in the
> {{fs.delete()}} operation to a {{LOG.error()}} instead.
> This will stop failures in teardown becoming a distraction from the root
> causes of the problem (that your FileSystem is broken)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
