[ 
https://issues.apache.org/jira/browse/HADOOP-8921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Giridharan Kesavan updated HADOOP-8921:
---------------------------------------

    Attachment: hadoop-8921.6.patch

I agree with Brandon. compile-native target was made available for the purpose 
of building libhadoop without having to set the compile.native flag. 

Yes, I agree, when calling compile-core-native without setting compile.native 
flag autoreconf should get triggered. 

Here is what I propose, How about moving the depends into antcalls inside the 
compile-core-native? by doing so the autoreconf won't get triggered if 
compile.native is not set.

Finally if we think task-controller target should be controlled with 
compile.native flag then we should mark this jira "incompatible" At least for 
me I do ant task-controller and expect it to build. 

here is my v6 patch with my thoughts above.
                
> ant build.xml in branch-1 ignores -Dcompile.native
> --------------------------------------------------
>
>                 Key: HADOOP-8921
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8921
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 1.2.0
>         Environment: Mac OS X 10.7.4
>            Reporter: Gopal V
>            Priority: Trivial
>              Labels: ant, autoconf, patch
>         Attachments: HADOOP-8921.4.patch, HADOOP-8921.5.patch, 
> hadoop-8921.6.patch
>
>
> ant -Dcompile.native=false still runs autoconf and libtoolize
> According to ant 1.8 manual, any <target if> conditions are checked only 
> after the dependencies are run through. The current if condition in code 
> fails to prevent the autoconf/libtool components from running.
> Fixing it by moving the if condition up into the "compile-native" target and 
> changing it to a param substitution instead of being evaluated as a condition.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to