[ 
https://issues.apache.org/jira/browse/HADOOP-9279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13571502#comment-13571502
 ] 

Chris Nauroth commented on HADOOP-9279:
---------------------------------------

Hi, Tsuyoshi.  Thanks for the patch, and sorry if the recent change in 
HADOOP-8924 caused any surprises.

We shouldn't need to pre-install hadoop-maven-plugins when running a 
distribution build from the top-level of the repo, because hadoop-maven-plugins 
gets built in the Maven reactor before any other sub-modules need to use it.  I 
just confirmed that this works by deleting hadoop-maven-plugins from my cached 
local Maven repository and running the full distro with the --offline flag so 
that it wouldn't attempt to resolve from a remote repository.

However, for anyone who wants to build a distro for just one of the sub-modules 
instead of the whole repo, you are correct that they would first need to run 
mvn install on hadoop-maven-plugins (or the whole repo).

I suggest moving the new information to the bottom of BUILDING.txt and stating 
that the extra step is only required for building individual sub-modules and 
not the whole project.  That way, developers who typically build the whole 
distro won't need to spend time on the extra step.

Also, could you generate the patch without path prefixes?  If you're using git, 
this would be "git diff --no-prefix > HADOOP-9279.patch".  The automated test 
patch process expects this format, because it tries to apply it with "patch 
-p0".

Thanks again!

                
> Compile failure when hadoop-maven-plugins doesn't exist in local repository
> ---------------------------------------------------------------------------
>
>                 Key: HADOOP-9279
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9279
>             Project: Hadoop Common
>          Issue Type: Improvement
>         Environment: hadoop-maven-plugins-3.0.0-SNAPSHOT.jar doesn't exist in 
> local repository or at maven central repository.
>            Reporter: Tsuyoshi OZAWA
>            Assignee: Tsuyoshi OZAWA
>         Attachments: HADOOP-9279.patch
>
>
> In current hadoop-trunk, compile fails when 
> hadoop-maven-plugins-3.0.0-SNAPSHOT.jar doesn't exist in local repository or 
> at maven central repository.
> The affected components are:
> ./hadoop-common-project/hadoop-common/pom.xml
> ./hadoop-maven-plugins/pom.xml
> ./hadoop-project/pom.xml
> ./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/pom.xml
> The error log is as follows
> {quote}
> [ERROR] Plugin org.apache.hadoop.maven.plugin:hadoop-maven-plugins:1.0 or one 
> of its dependencies could not be resolved: Failed to read artifact descriptor 
> for org.apache.hadoop.maven.plugin:hadoop-maven-plugins:jar:1.0: Could not 
> find artifact org.apache.hadoop.maven.plugin:hadoop-maven-plugins:pom:1.0 in 
> central (http://repo.maven.apache.org/maven2) -> [Help 1]
> {quote}
> This can be avoidable if hadoop-maven-plugins is installed before packaging. 
> This is undocumented, so this should get documented.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to