[ 
https://issues.apache.org/jira/browse/HADOOP-8934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13575833#comment-13575833
 ] 

Daryn Sharp commented on HADOOP-8934:
-------------------------------------

Looks good!  {{isOrderMtime}} is a bit misleading since it might be sorting by 
mtime or atime.  I'd suggest {{isOrderByTime}}?

Well I admire the thoroughness of the tests, please don't test the usage and 
description in your new tests since it duplicates the checks in 
{{testConf.xml}}.  It'd be a pain to update two different tests in common for 
the same thing.
                
> Shell command ls should include sort options
> --------------------------------------------
>
>                 Key: HADOOP-8934
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8934
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs
>            Reporter: Jonathan Allen
>            Assignee: Jonathan Allen
>            Priority: Minor
>         Attachments: HADOOP-8934.patch, HADOOP-8934.patch, HADOOP-8934.patch, 
> HADOOP-8934.patch
>
>
> The shell command ls should include options to sort the output similar to the 
> unix ls command.  The following options seem appropriate:
> -t : sort by modification time
> -S : sort by file size
> -r : reverse the sort order
> -u : use access time rather than modification time for sort and display

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to