[
https://issues.apache.org/jira/browse/HADOOP-9112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Surenkumar Nihalani updated HADOOP-9112:
----------------------------------------
Attachment: HADOOP-9112-2.patch
There are five possibilities for JUnit's test annonation as per the
documentation:
- @Test
- @Test()
- @Test(timeout=x)
- @Test(exception=x.class)
- @Test(timeout=x, exception=y.class)
- @Test(exception=y.class, timeout=y)
Out of these, the current regex detects first three and we should fine.
However, I couldn't get it to be newline safe. If any knows how to, feel free
to update the patch. Thanks.
> test-patch should -1 for @Tests without a timeout
> -------------------------------------------------
>
> Key: HADOOP-9112
> URL: https://issues.apache.org/jira/browse/HADOOP-9112
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Todd Lipcon
> Assignee: Surenkumar Nihalani
> Attachments: HADOOP-9112-1.patch, HADOOP-9112-2.patch
>
>
> With our current test running infrastructure, if a test with no timeout set
> runs too long, it triggers a surefire-wide timeout, which for some reason
> doesn't show up as a failed test in the test-patch output. Given that, we
> should require that all tests have a timeout set, and have test-patch enforce
> this with a simple check
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
