[ 
https://issues.apache.org/jira/browse/HADOOP-9112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13583123#comment-13583123
 ] 

Surenkumar Nihalani commented on HADOOP-9112:
---------------------------------------------

[[email protected]], having a recommended value works, I was thinking of 
having intermediate value substitution in test-patch. If the value is x, and 
the coefficient of my machine (>= 1), we could have it configurable so that it 
substitutes {{(long)(coefficient * valueOfTimeoutForThat@Test)}} This way if 
anyone faces timeout exceptions, we can keep on increasing the configurable 
coefficient till all of the tests pass as part of initial setup.

Would that be too much overhead for configuration?
                
> test-patch should -1 for @Tests without a timeout
> -------------------------------------------------
>
>                 Key: HADOOP-9112
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9112
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Todd Lipcon
>            Assignee: Surenkumar Nihalani
>             Fix For: 3.0.0
>
>         Attachments: HADOOP-9112-1.patch, HADOOP-9112-2.patch, 
> HADOOP-9112-3.patch, HADOOP-9112-4.patch, HADOOP-9112-5.patch, 
> HADOOP-9112-6.patch, HADOOP-9112-7.patch
>
>
> With our current test running infrastructure, if a test with no timeout set 
> runs too long, it triggers a surefire-wide timeout, which for some reason 
> doesn't show up as a failed test in the test-patch output. Given that, we 
> should require that all tests have a timeout set, and have test-patch enforce 
> this with a simple check

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to