[ 
https://issues.apache.org/jira/browse/HADOOP-9347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13590044#comment-13590044
 ] 

Arpit Agarwal commented on HADOOP-9347:
---------------------------------------

{code}Several tests requires that the user must have the Create Symbolic Links
+privilege.{code}
Grammar nitpick - should be "Several tests require".

{code}Set environment variable "Platform" to "x64" or "Win32", depending on 
whether{code}
Sorry about not mentioning this earlier. Failure to set it causes a confusing 
error code from the C compiler that is hard to diagnose as the missing 
environment setting. So maybe we can make this suggestion more forceful e.g. 
"You must set the Platform environment variable". Also, environment variables 
on Windows are usually case-insensitive but Maven appears to treat them as 
case-sensitive, so PLATFORM or platform would not work here. It took me a while 
to figure out when I hit it.


{code}set Platform=x64{code}
Related to the above, just suggesting some rewording.
- set Platform=x64 (when building on a 64-bit system)
- set Platform=Win32 (when building on a 32-bit system)


+1 otherwise.
                
> add instructions to BUILDING.txt describing how to build on Windows
> -------------------------------------------------------------------
>
>                 Key: HADOOP-9347
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9347
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: documentation
>    Affects Versions: trunk-win
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>         Attachments: HADOOP-9347-branch-trunk-win.1.patch, 
> HADOOP-9347-branch-trunk-win.2.patch
>
>
> Add documentation to BUILDING.txt describing dependencies and instructions 
> for building on Windows.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to