[ 
https://issues.apache.org/jira/browse/HADOOP-9356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13592771#comment-13592771
 ] 

Suresh Srinivas commented on HADOOP-9356:
-----------------------------------------

Chris, I see some more references to cygwin in the code base. Should it be 
removed as well?

{noformat}
./BUILDING.txt:* Unix command-line tools from GnuWin32 or Cygwin: sh, mkdir, 
rm, cp, tar, gzip
./hadoop-common-project/hadoop-common/src/main/docs/releasenotes.html:     
<b>compilation of protobuf files fails in windows/cygwin</b><br>
./hadoop-common-project/hadoop-common/src/main/docs/src/documentation/content/xdocs/site.xml:
    <cygwin    href="http://www.cygwin.com/"; />
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/DF.java:
 * space utilization. Tested on Linux, FreeBSD, Cygwin. */
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileUtil.java:
   * Supports Unix, Cygwin, WindXP.
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/HardLink.java:
   * a Cygwin shell command, and depends on ${cygwin}/bin
./hadoop-common-project/hadoop-common/src/main/java/overview.html:    <a 
href="http://www.cygwin.com/";>Cygwin</a> - Required for shell support in 
./hadoop-common-project/hadoop-common/src/main/java/overview.html:installed 
cygwin, start the cygwin installer and select the packages:</p>
./hadoop-common-project/hadoop-common/src/site/apt/NativeLibraries.apt.vm:   
library does not to work with Cygwin or the Mac OS X platform.
./hadoop-common-project/hadoop-common/src/site/apt/SingleNodeSetup.apt.vm:    
[[1]] Cygwin - Required for shell support in addition to the required
./hadoop-common-project/hadoop-common/src/site/apt/SingleNodeSetup.apt.vm:   
installed cygwin, start the cygwin installer and select the packages:
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestLocalDirAllocator.java:
 * This test does not run on Cygwin because under Cygwin
./hadoop-hdfs-project/hadoop-hdfs/src/main/docs/src/documentation/content/xdocs/site.xml:
    <cygwin    href="http://www.cygwin.com/"; />
./hadoop-hdfs-project/hadoop-hdfs/src/main/java/overview.html:    <a 
href="http://www.cygwin.com/";>Cygwin</a> - Required for shell support in 
./hadoop-hdfs-project/hadoop-hdfs/src/main/java/overview.html:installed cygwin, 
start the cygwin installer and select the packages:</p>
./hadoop-hdfs-project/hadoop-hdfs/src/main/native/tests/test-libhdfs.sh:    
cygwin* | mingw* | pw23* )
./hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDiskError.java:
       * not the case on Windows (at least under Cygwin), and possibly AIX.
./hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapred/TestCounters.java:
  public void testLegacyGetGroupNames() {
./hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/testshell/ExternalMapReduce.java:
      // cygwin since it is a symlink
./hadoop-tools/hadoop-streaming/src/test/java/org/apache/hadoop/streaming/UtilTest.java:
  public static boolean isCygwin() {
./hadoop-yarn-project/hadoop-yarn/bin/yarn:cygwin=false
./hadoop-yarn-project/hadoop-yarn/bin/yarn:CYGWIN*) cygwin=true;;
{noformat}
                
> remove remaining references to cygwin/cygpath from scripts
> ----------------------------------------------------------
>
>                 Key: HADOOP-9356
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9356
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build, scripts
>    Affects Versions: trunk-win
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>         Attachments: HADOOP-9356-branch-trunk-win.1.patch
>
>
> branch-trunk-win still contains a few references to Cygwin and the cygpath 
> command that need to be removed now that they are no longer needed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to