[ 
https://issues.apache.org/jira/browse/HADOOP-9356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Nauroth updated HADOOP-9356:
----------------------------------

    Attachment: HADOOP-9356-branch-trunk-win.2.patch

Thanks, Suresh.  There were a few pieces of script that I missed.  I also 
didn't realize some of the documentation mentioned Cygwin.  I'm uploading a new 
patch to fix this.

Grep will still show a few occurrences of "cygwin", but I think these should be 
left in place, at least for now:

# BUILDING.txt documents the small number of remaining Unix utilities still 
required for building.
# CHANGES.txt and releasenotes.html mention old jiras pertaining to Cygwin 
support, so we wouldn't retroactively edit the change log.
# NativeLibraries.apt.vm mentions that libhadoop.so doesn't work on Cygwin.
# TestLocalDirAllocator and TestDiskError have comments stating that some tests 
don't run on Windows for platform-specific reasons.  Since this involves actual 
code, I recommend that we file a separate jira to determine if we can re-enable 
these tests, and if not, then change the comment from "Cygwin" to "Windows".
# {{UtilTest#isCygwin}} appears to be an unused method.  Again, since this is 
actual code, I recommend that we file a separate jira to track removing the 
method.

                
> remove remaining references to cygwin/cygpath from scripts
> ----------------------------------------------------------
>
>                 Key: HADOOP-9356
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9356
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build, scripts
>    Affects Versions: trunk-win
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>         Attachments: HADOOP-9356-branch-trunk-win.1.patch, 
> HADOOP-9356-branch-trunk-win.2.patch
>
>
> branch-trunk-win still contains a few references to Cygwin and the cygpath 
> command that need to be removed now that they are no longer needed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to