[ 
https://issues.apache.org/jira/browse/HADOOP-9364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Nauroth updated HADOOP-9364:
----------------------------------

    Attachment: HADOOP-9364.2.patch

+1

The patch looks good.  I verified that the test passes on Mac with the patch 
applied to either trunk or branch-trunk-win.  On Windows, I verified that the 
test passes, and I verified that manually running hadoop fs -ls commands no 
longer has the erroneous leading "../.." .

I'm attaching the same patch generated a slightly different way just so that it 
can apply cleanly to trunk and then merge to branch-trunk-win.  Also, really 
minor nit: instead of globUri.getPath().equals(""), we can use 
globUri.getPath().isEmpty().  I changed it in the new patch.

Thanks!

                
> PathData#expandAsGlob does not return correct results for absolute paths on 
> Windows
> -----------------------------------------------------------------------------------
>
>                 Key: HADOOP-9364
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9364
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 3.0.0, trunk-win
>            Reporter: Ivan Mitic
>            Assignee: Ivan Mitic
>         Attachments: HADOOP-9364.2.patch, 
> HADOOP-9364.branch-trunk-win.pathdata.patch
>
>
> This causes {{FsShell ls}} not to work properly for absolute paths. For 
> example:
> {code}
> -fs hdfs://127.0.0.1:58559 -ls -R /dir0
> {code}
> returns
> {code}
> drwxr-xr-x   - ivanmi supergroup          0 2013-03-05 11:15 ../../dir0/dir1
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to