[ 
https://issues.apache.org/jira/browse/HADOOP-8973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13594927#comment-13594927
 ] 

Bikas Saha commented on HADOOP-8973:
------------------------------------

bq. Can we please keep the scope of this jira limited to Windows compatibility 
for the current logic?
Not until we clearly understand what the flaw is that we are trying to fix. It 
this was branch-1 then I would agree. But on trunk we have the flexibility of 
not making stop-gap changes.

As far as the permissions is concerned. I think Hadoop really depends on a Unix 
like rwx permission model on the local disk. This is in theory unrelated to the 
permission model HFDS itself imposes for its own filesystem and which also 
happens to be the rwx model. This is the main reason why we wrote the winutil 
layer that exposes the rwx model on top of Windows ACL's for local disk. Thats 
why I am trying to understand why we need different checks here because it may 
imply that our translation layer is not working.
Your analysis might be correct and I would like an HDFS expert like 
[~sanjay.radia] to take a look.

This jira was opened because TestDiskChecker was failing right? Would you be 
kind enough to change checkDir(File) to use the same logic as checkDir(FS, 
Path, perm) and check if the test passes? Hopefully the change will be small 
and wont take much of your time. It will help ascertain if the implies function 
will work or not.
                
> DiskChecker cannot reliably detect an inaccessible disk on Windows with NTFS 
> ACLs
> ---------------------------------------------------------------------------------
>
>                 Key: HADOOP-8973
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8973
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: util
>    Affects Versions: trunk-win
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>         Attachments: HADOOP-8973-branch-trunk-win.2.patch, 
> HADOOP-8973-branch-trunk-win.patch
>
>
> DiskChecker.checkDir uses File.canRead, File.canWrite, and File.canExecute to 
> check if a directory is inaccessible.  These APIs are not reliable on Windows 
> with NTFS ACLs due to a known JVM bug.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to