[ 
https://issues.apache.org/jira/browse/HADOOP-8973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13597686#comment-13597686
 ] 

Chris Nauroth commented on HADOOP-8973:
---------------------------------------

{quote}
I noticed that testCheckDir_notListable and testCheckDir_notListable_local fail 
on my machine (stacks are below, will take a look now) (hint: I am running as 
admin)
{quote}

Ivan, I would appreciate any help you can offer on this.  I can't repro the 
problem on my side, even when running as admin.  I'm on Windows Server 2008 R2 
64-bit (in case specific Windows version is causing a difference).

{quote}
I would prefer that we make Shell#getSetPermissionCommand accept File instead 
of a string (we should do the same for other Shell methods that accept local 
paths, but this is orthogonal)
{quote}

Please note that I am only merging an existing Shell method from trunk to 
branch-1-win.  If we make it accept File on branch-1-win, then we'll set 
ourselves up for merge conflicts later as we try to manage patches across the 2 
branches.  If we change the trunk version, then it's going to break about 15 
different call sites that have nothing to do with DiskChecker, so it's not 
appropriate to change the trunk version within the scope of this jira.  The 
safest option is to defer this change to a different jira for refactoring all 
of the Shell methods like you suggested.  Is there a jira for that yet?

                
> DiskChecker cannot reliably detect an inaccessible disk on Windows with NTFS 
> ACLs
> ---------------------------------------------------------------------------------
>
>                 Key: HADOOP-8973
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8973
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: util
>    Affects Versions: 3.0.0, 1-win
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>         Attachments: HADOOP-8973.3.patch, HADOOP-8973-branch-1-win.3.patch, 
> HADOOP-8973-branch-trunk-win.2.patch, HADOOP-8973-branch-trunk-win.patch
>
>
> DiskChecker.checkDir uses File.canRead, File.canWrite, and File.canExecute to 
> check if a directory is inaccessible.  These APIs are not reliable on Windows 
> with NTFS ACLs due to a known JVM bug.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to