[
https://issues.apache.org/jira/browse/HADOOP-9389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zhijie Shen updated HADOOP-9389:
--------------------------------
Attachment: HADOOP-9389_1.patch
The line of "+" with a number of following whilespace characters needs to be
skipped, such that the context @Test will not be regarded as a newly added test
by mistake.
> test-patch marks -1 due to a context @Test by mistake
> -----------------------------------------------------
>
> Key: HADOOP-9389
> URL: https://issues.apache.org/jira/browse/HADOOP-9389
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Zhijie Shen
> Attachments: HADOOP-9389_1.patch
>
>
> HADOOP-9112 enables the function of marking -1 when the newly added tests
> don't have timeout. However, test-patch will mark -1 due to a context @Test
> by mistake. Bellow is the problematic part of the YARN-378_3.patch that I've
> created.
> {code}
> + }
> + }
> +
> @Test
> public void testRMAppSubmitWithQueueAndName() throws Exception {
> long now = System.currentTimeMillis();
> {code}
> There's a @Test without timeout (most existing tests don't have timeout) in
> the context. In test-patch, $AWK '\{ printf "%s ", $0 \}' collapses these
> lines into one line, i.e.,
> {code}
> + } + } + @Test public void testRMAppSubmitWithQueueAndName()
> throws Exception { long now = System.currentTimeMillis();
> {code}
> Then, @Test in the context follows a "+", and is regarded as a newly added
> test by mistake. Consequently, the following regex will accept the context
> @Test.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
