[ 
https://issues.apache.org/jira/browse/HADOOP-9437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13617131#comment-13617131
 ] 

Ivan Mitic commented on HADOOP-9437:
------------------------------------

I see, thanks for double checking Chris!

OK, I have one more minor comment since we're changing the native code anyways. 
To be semantically correct, we cannot assume that last error is properly set 
when we call the CRT rename API (its undocumented). Can we instead call 
[MoveFile|http://msdn.microsoft.com/en-us/library/windows/desktop/aa365239(v=vs.85).aspx]
 on Windows? (this is what rename does internally) Feel free to comment back 
with your take.
                
> TestNativeIO#testRenameTo fails on Windows due to assumption that POSIX errno 
> is embedded in NativeIOException
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-9437
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9437
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 3.0.0
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>         Attachments: HADOOP-9437.1.patch, HADOOP-9437.2.patch
>
>
> HDFS-4428 added a detailed error message for failures to rename files by 
> embedding the POSIX errno in the {{NativeIOException}}.  On Windows, the 
> mapping of errno is not performed, so the errno enum value will not be 
> present in the {{NativeIOException}}.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to