[
https://issues.apache.org/jira/browse/HADOOP-9233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Lowe updated HADOOP-9233:
-------------------------------
Status: Open (was: Patch Available)
Thanks for posting a patch for this, Vadim. A few comments:
CompressDecompressTester.java:
* The {{Visitor}} interface has exactly one class that implements it, exactly
one instance of that class, and exactly one function that calls the interface.
This seems like abstraction layers that are making the code harder to read and
not adding any value, or do you have future expansion plans for this? It would
be a lot simpler to just have a static function that takes compressor object
and returns a boolean on whether it's available.
TestCompressorDecompressor.java:
* Nit: Any reason why line 110 isn't just:
{code}
byte[] array = new byte[size];
{code}
* Rather than an explicit array with values from 0x0-0xF, can't we just use the
value returned from {{rnd.nextInt(15)}} directly?
* There are a number of unused imports.
TestZlibCompressorDecompressor.java:
* There are a number of unused imports.
* In {{testZlibCompressorDecompressorWithConfiguration}} and
{{testZlibCompressorDecompressorSetDictionary}} we are using {{assertFalse}} on
a condition that was just checked by the {{if}} statement as false so this
assert will never fire.
Also note that it's unnecessary to post separate patches for branch-2 and
branch-0.23 if the trunk patch will apply to them as well.
> Cover package org.apache.hadoop.compress.zlib with unit tests
> -------------------------------------------------------------
>
> Key: HADOOP-9233
> URL: https://issues.apache.org/jira/browse/HADOOP-9233
> Project: Hadoop Common
> Issue Type: Test
> Affects Versions: 2.0.3-alpha, 3.0.0, 0.23.6
> Reporter: Vadim Bondarev
> Assignee: Vadim Bondarev
> Attachments: HADOOP-9233-branch-0.23-b.patch,
> HADOOP-9233-branch-2-a.patch, HADOOP-9233-branch-2-b.patch,
> HADOOP-9233-trunk-a.patch, HADOOP-9233-trunk-b.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
