[
https://issues.apache.org/jira/browse/HADOOP-9470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13628851#comment-13628851
]
Hadoop QA commented on HADOOP-9470:
-----------------------------------
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12578190/HADOOP-9470-trunk.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 9 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/2443//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/2443//console
This message is automatically generated.
> eliminate duplicate FQN tests in different Hadoop modules
> ---------------------------------------------------------
>
> Key: HADOOP-9470
> URL: https://issues.apache.org/jira/browse/HADOOP-9470
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 3.0.0, 0.23.7, 2.0.4-alpha
> Reporter: Ivan A. Veselovsky
> Assignee: Ivan A. Veselovsky
> Attachments: find-duplicate-fqns.sh, HADOOP-9470-branch-0.23.patch,
> HADOOP-9470-trunk.patch
>
>
> In different modules of Hadoop project there are tests with identical FQNs
> (fully qualified name).
> For example, test with FQN org.apache.hadoop.util.TestRunJar is contained in
> 2 modules:
>
> ./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestRunJar.java
>
> ./hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/util/TestRunJar.java
>
> Such situation causes certain problems with test result reporting and other
> code analysis tools (such as Clover, e.g.) because almost all the tools
> identify the tests by their Java FQN.
> So, I suggest to rename all such test classes to avoid duplicate FQNs in
> different modules. I'm attaching simple shell script that can find all such
> problematic test classes. Currently Hadoop trunk has 9 such test classes,
> they are:
> $ ~/bin/find-duplicate-fqns.sh
> ##### Module
> [./hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/target/test-classes]
> has 7 duplicate FQN tests:
> org.apache.hadoop.ipc.TestSocketFactory
> org.apache.hadoop.mapred.TestFileOutputCommitter
> org.apache.hadoop.mapred.TestJobClient
> org.apache.hadoop.mapred.TestJobConf
> org.apache.hadoop.mapreduce.lib.output.TestFileOutputCommitter
> org.apache.hadoop.util.TestReflectionUtils
> org.apache.hadoop.util.TestRunJar
> ##### Module
> [./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/target/test-classes]
> has 2 duplicate FQN tests:
> org.apache.hadoop.yarn.TestRecordFactory
> org.apache.hadoop.yarn.TestRPCFactories
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
