[
https://issues.apache.org/jira/browse/HADOOP-9490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13638338#comment-13638338
]
Chris Nauroth commented on HADOOP-9490:
---------------------------------------
+1 for the patch. I applied it in combination with HADOOP-9413 and verified
successful test runs on Mac and Windows.
Minor question: instead of {{LocalFileSystem}}, do you think the close should
happen inside {{ChecksumFileSystem#ChecksumFSInputChecker#seekToNewSource}}
right before the call to {{reportChecksumFailure}}, since this is the class
that initially opened the checksum file and owns it? Either way, I am +1.
> LocalFileSystem#reportChecksumFailure not closing the checksum file handle
> before rename
> ----------------------------------------------------------------------------------------
>
> Key: HADOOP-9490
> URL: https://issues.apache.org/jira/browse/HADOOP-9490
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 3.0.0
> Reporter: Ivan Mitic
> Assignee: Ivan Mitic
> Attachments: HADOOP-9490.patch
>
>
> LocalFileSystem#reportChecksumFailure is not closing the open stream on the
> checksum file before it moves it to the bad_files folder, what causes the
> operation to fail on Windows.
> TestLocalFileSystem fail on Windows because of this:
> {code}
> testReportChecksumFailure(org.apache.hadoop.fs.TestLocalFileSystem) Time
> elapsed: 31 sec <<< FAILURE!
> java.lang.AssertionError:
> at org.junit.Assert.fail(Assert.java:91)
> at org.junit.Assert.assertTrue(Assert.java:43)
> at org.junit.Assert.assertTrue(Assert.java:54)
> at
> org.apache.hadoop.fs.TestLocalFileSystem.testReportChecksumFailure(TestLocalFileSystem.java:335)
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
