[
https://issues.apache.org/jira/browse/HADOOP-9502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13641086#comment-13641086
]
Tsz Wo (Nicholas), SZE commented on HADOOP-9502:
------------------------------------------------
{noformat}
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] -1 tests included. The patch doesn't appear to include any new
or modified tests.
[exec] Please justify why no tests are needed for
this patch.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning
messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number
of javac compiler warnings.
[exec]
[exec] -1 findbugs. The patch appears to introduce 19 new Findbugs
(version 1.3.9) warnings.
{noformat}
The fingbugs warnings are not related.
I tested the patch manually. It worked well.
> chmod does not return error exit codes for some exceptions
> ----------------------------------------------------------
>
> Key: HADOOP-9502
> URL: https://issues.apache.org/jira/browse/HADOOP-9502
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Reporter: Ramya Sunil
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Minor
> Attachments: c9502_20130424.patch
>
>
> When some dfs operations fail due to SnapshotAccessControlException, valid
> exit codes are not returned.
> E.g:
> {noformat}
> -bash-4.1$ hadoop dfs -chmod -R 755
> /user/foo/hdfs-snapshots/test0/.snapshot/s0
> chmod: changing permissions of
> 'hdfs://<namenode>:8020/user/foo/hdfs-snapshots/test0/.snapshot/s0':org.apache.hadoop.hdfs.server.namenode.snapshot.SnapshotAccessControlException:
> Modification on read-only snapshot is disallowed
> -bash-4.1$ echo $?
> 0
> -bash-4.1$ hadoop dfs -chown -R hdfs:users
> /user/foo/hdfs-snapshots/test0/.snapshot/s0
> chown: changing ownership of
> 'hdfs://<namenode>:8020/user/foo/hdfs-snapshots/test0/.snapshot/s0':org.apache.hadoop.hdfs.server.namenode.snapshot.SnapshotAccessControlException:
> Modification on read-only snapshot is disallowed
> -bash-4.1$ echo $?
> 0
> {noformat}
> Similar problems exist for some other exceptions such as SafeModeException.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
