[ 
https://issues.apache.org/jira/browse/HADOOP-9483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13647347#comment-13647347
 ] 

Ivan Mitic commented on HADOOP-9483:
------------------------------------

Thanks Arpit, looks good. Sorry, just realized that I missed the below comment, 
otherwise I am +1

Should we allocate an array of size {{printNameLength+1}}?
{code}
printName = (PWCHAR) LocalAlloc(LMEM_FIXED, printNameLength);
{code}
                
> winutils support for readlink command
> -------------------------------------
>
>                 Key: HADOOP-9483
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9483
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: util
>    Affects Versions: 3.0.0
>            Reporter: Chris Nauroth
>            Assignee: Arpit Agarwal
>         Attachments: HADOOP-9483.003.patch, HADOOP-9483.004.patch, 
> HADOOP-9483.patch, HADOOP-9483.patch
>
>
> The current codebase relies on the Unix readlink command to determine the 
> target of a symlink on the local file system.  winutils currently does not 
> support this functionality on Windows.  Adding the command to winutils will 
> prevent the need to use GnuWin32 or Cygwin for readlink support.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to