[ 
https://issues.apache.org/jira/browse/HADOOP-9574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13669543#comment-13669543
 ] 

Hadoop QA commented on HADOOP-9574:
-----------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12585265/HADOOP-9574.2.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new 
or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-common-project/hadoop-common.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/2577//testReport/
Console output: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/2577//console

This message is automatically generated.
                
> Add new methods in AbstractDelegationTokenSecretManager for restoring 
> RMDelegationTokens on RMRestart
> -----------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-9574
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9574
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Jian He
>            Assignee: Jian He
>         Attachments: HADOOP-9574.1.patch, HADOOP-9574.2.patch
>
>
> we're considering to add the following methods in 
> AbstractDelegationTokenSecretManager for restoring RMDelegationTokens, these 
> methods can also possibly be reused by hdfsDelegationTokenSecretManager, see 
> YARN-638
>   protected void storeNewMasterKey(DelegationKey key) throws IOException {
>     return;
>   }
>   protected void removeStoredMasterKey(DelegationKey key) {
>     return;
>   }
>   protected void storeNewToken(TokenIdent ident, long renewDate) {
>     return;
>   }
>   protected void removeStoredToken(TokenIdent ident) throws IOException {
>   }
>   protected void updateStoredToken(TokenIdent ident, long renewDate) {
>     return;
>   }
> Also move addPersistedDelegationToken in hdfs.DelegationTokenSecretManager, 
> to AbstractDelegationTokenSecretManager

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to