[ 
https://issues.apache.org/jira/browse/HADOOP-9527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arpit Agarwal updated HADOOP-9527:
----------------------------------

    Attachment: HADOOP-9527.008.patch

New patch. This is actually a simpler approach more in line with branch-1.

I tested with JDK6 and JDK7 on Windows, and JDK6 on OS X.

{quote}
2. FileUtil#readLink: My preference would be to expose a single File 
readLink(File) public API instead of FileUtil APIs that accept Paths or 
Strings. This makes the contract explicit such that the input path must be a 
valid cross-platform local file system path.
{quote}
Ivan, I've not addressed this. Other methods in FileUtil take String/Path and 
it complicates the calling code a bit.

Let me know what you think.

Arpit
                
> TestLocalFSFileContextSymlink is broken on Windows
> --------------------------------------------------
>
>                 Key: HADOOP-9527
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9527
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 3.0.0, 2.3.0
>            Reporter: Arpit Agarwal
>            Assignee: Arpit Agarwal
>             Fix For: 3.0.0, 2.3.0
>
>         Attachments: HADOOP-9527.001.patch, HADOOP-9527.002.patch, 
> HADOOP-9527.003.patch, HADOOP-9527.004.patch, HADOOP-9527.005.patch, 
> HADOOP-9527.006.patch, HADOOP-9527.007.patch, HADOOP-9527.008.patch, 
> RenameLink.java
>
>
> Multiple test cases are broken. I didn't look at each failure in detail.
> The main cause of the failures appears to be that RawLocalFS.readLink() does 
> not work on Windows. We need "winutils readlink" to fix the test.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to