[ 
https://issues.apache.org/jira/browse/HADOOP-8934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13680041#comment-13680041
 ] 

Jing Zhao commented on HADOOP-8934:
-----------------------------------

Hi Jonathan,

   The patch looks pretty good to me. The only minor nit is in the description 
of LS:

{code}
  public static final String DESCRIPTION =
    "List the contents that match the specified file pattern. If\n"
    + "path is not specified, the contents of /user/<currentUser>\n"
    + "will be listed. For a directory a list of its direct children\n"
    + "is returned (unless -" + OPTION_DIRECTORY + " option is specified).
{code}

   Looks like if the path is not specified, in trunk we cannot get the content 
of /user/<currentUser>? And if OPTION_RECURSIVE is specified, we will get more 
than _direct_ children.
                
> Shell command ls should include sort options
> --------------------------------------------
>
>                 Key: HADOOP-8934
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8934
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs
>            Reporter: Jonathan Allen
>            Assignee: Jonathan Allen
>            Priority: Minor
>         Attachments: HADOOP-8934.patch, HADOOP-8934.patch, HADOOP-8934.patch, 
> HADOOP-8934.patch, HADOOP-8934.patch
>
>
> The shell command ls should include options to sort the output similar to the 
> unix ls command.  The following options seem appropriate:
> -t : sort by modification time
> -S : sort by file size
> -r : reverse the sort order
> -u : use access time rather than modification time for sort and display

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to