[
https://issues.apache.org/jira/browse/HADOOP-9637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chuan Liu updated HADOOP-9637:
------------------------------
Attachment: HADOOP-9637-trunk.patch
Post a patch. In this patch, I implemented {{NativeIO.POSIX.getFstat()}} for
Windows. There are some minimal refactoring in winutils to make this work,
including:
1. Moved symlink and directory check from '{{Ls()}}' method to
'{{FindFileOwnerAndPermission()}}'.
2. Added an additional mode flag equivalent of S_IFREG on Linux.
3. Added '{{FindFileOwnerAndPermissionByHandle()}}' method -- a lightweight
method that calls '{{FindFileOwnerAndPermission()}}'. The Java native method
{{fstat()}} on Windows directly calls this new method to get file stat.
4. Enabled two TestNativeIO test cases, {{testFstat}} and
{{testFstatClosedFdfor}}, that are previously disabled on Windows.
5. In {{NativeIO.POSIX.getFstat()}}, I used the similar pattern as
{{NativeIO.POSIX.chmod()}} to map the Windows Error 6 (ERROR_INVALID_HANDLE:
The handle is invalid ) to Linux exception Errno.EBADF. In analog, {{chmod()}}
maps Windows error code 3 ERROR_PATH_NOT_FOUND to Linux Errno.ENOENT.
> TestAggregatedLogFormat fails on Windows
> ----------------------------------------
>
> Key: HADOOP-9637
> URL: https://issues.apache.org/jira/browse/HADOOP-9637
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 3.0.0, 2.1.0-beta
> Reporter: Chuan Liu
> Assignee: Chuan Liu
> Attachments: HADOOP-9637-trunk.patch
>
>
> TestAggregatedLogFormat.testContainerLogsFileAccess test case fails on
> Windows. The test case try to simulate a situation where first log file is
> owned by different user (probably symlink) and second one by the user itself.
> In this situation, the attempt to try to aggregate the logs should fail with
> the error message "Owner ... for path ... did not match expected owner ...".
> The check on file owner happens at {{AggregatedLogFormat.write()}} method.
> The method calls {{SecureIOUtils.openForRead()}} to read the log files before
> writing out to the OutputStream.
> {{SecureIOUtils.openForRead()}} use {{NativeIO.Posix.getFstat()}} to get the
> file owner and group. We don't have {{NativeIO.Posix.getFstat()}}
> implementation on Windows; thus, the failure.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
