[ 
https://issues.apache.org/jira/browse/HADOOP-9638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Nauroth updated HADOOP-9638:
----------------------------------

    Attachment: HADOOP-9638.2.patch

Thanks, Andrey.  This looks good.  I found one more thing that needed to be 
fixed for {{TestHDFSFileContextMainOperations}}.  It inherits from 
{{FileContextMainOperationsBaseTest}}, which had a hard-coded call to the 
default constructor of {{FileContextTestHelper}}.  Rather than go back and 
forth on this, I tested a change similar to what you did elsewhere, and it 
passed on Windows.  I'm attaching version 2 of the patch, which includes that 
change.

Aside from that just a couple of minor style nitpicks:

# {{FileContextTestHelper}} has some lines indented by 4 spaces.  Can you 
please switch those to 2 spaces?
# The patch has a few lines that go past the 80-character limit when creating a 
new {{FileContextTestHelper}}.  Can you please split those, wrapping at 80 
characters?

                
> parallel test changes caused invalid test path for several HDFS tests on 
> Windows
> --------------------------------------------------------------------------------
>
>                 Key: HADOOP-9638
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9638
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 3.0.0, 2.1.0-beta
>            Reporter: Chris Nauroth
>            Assignee: Andrey Klochkov
>         Attachments: HADOOP-9638.2.patch, HADOOP-9638.patch
>
>
> HADOOP-9287 made changes to the tests to support running multiple tests in 
> parallel.  Part of that patch accidentally reverted a prior change to use 
> paths of the form "/tmp/<test name>" when running tests against HDFS.  On 
> Windows, use of the test root will contain a drive spec (i.e. C:\dir), and 
> the colon character is rejected as invalid by HDFS.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to