[ 
https://issues.apache.org/jira/browse/HADOOP-9646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Colin Patrick McCabe updated HADOOP-9646:
-----------------------------------------

    Description: 
There are two FileUtils#chmod methods:

{code}
public static int chmod(String filename, String perm
                          ) throws IOException, InterruptedException;
public static int chmod(String filename, String perm, boolean recursive)
                            throws IOException;
{code}

The first one just calls the second one with {{recursive = false}}, but despite 
that it is declared as throwing {{InterruptedException}}, something the second 
one doesn't declare.

The new Java7 chmod API, which we will transition to once JDK6 support is 
dropped, does *not* throw {{InterruptedException}}

See 
[http://docs.oracle.com/javase/7/docs/api/java/nio/file/Files.html#setOwner(java.nio.file.Path,
 java.nio.file.attribute.UserPrincipal)]

So we should make these consistent by removing the {{InterruptedException}}

  was:
There are two FileUtils#chmod methods:

{code}
public static int chmod(String filename, String perm
                          ) throws IOException, InterruptedException;
public static int chmod(String filename, String perm, boolean recursive)
                            throws IOException;
{code}

The first one just calls the second one with {{recursive = false}}, but despite 
that it is declared as throwing {{InterruptedException}}, something the second 
one doesn't call.

The new Java7 chmod API, which we will transition to once JDK6 support is 
dropped, does *not* throw {{InterruptedException}}

See 
[http://docs.oracle.com/javase/7/docs/api/java/nio/file/Files.html#setOwner(java.nio.file.Path,
 java.nio.file.attribute.UserPrincipal)]

So we should make these consistent by removing the {{InterruptedException}}

    
> Inconsistent exception specifications in FileUtils#chmod
> --------------------------------------------------------
>
>                 Key: HADOOP-9646
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9646
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>            Priority: Minor
>         Attachments: HADOOP-9646.001.patch
>
>
> There are two FileUtils#chmod methods:
> {code}
> public static int chmod(String filename, String perm
>                           ) throws IOException, InterruptedException;
> public static int chmod(String filename, String perm, boolean recursive)
>                             throws IOException;
> {code}
> The first one just calls the second one with {{recursive = false}}, but 
> despite that it is declared as throwing {{InterruptedException}}, something 
> the second one doesn't declare.
> The new Java7 chmod API, which we will transition to once JDK6 support is 
> dropped, does *not* throw {{InterruptedException}}
> See 
> [http://docs.oracle.com/javase/7/docs/api/java/nio/file/Files.html#setOwner(java.nio.file.Path,
>  java.nio.file.attribute.UserPrincipal)]
> So we should make these consistent by removing the {{InterruptedException}}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to