[
https://issues.apache.org/jira/browse/HADOOP-9624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13687184#comment-13687184
]
Hadoop QA commented on HADOOP-9624:
-----------------------------------
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12588443/HADOOP-9624.trunk.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/2666//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/2666//console
This message is automatically generated.
> TestFSMainOperationsLocalFileSystem failed when the Hadoop enlistment root
> path has "X" in its name
> ---------------------------------------------------------------------------------------------------
>
> Key: HADOOP-9624
> URL: https://issues.apache.org/jira/browse/HADOOP-9624
> Project: Hadoop Common
> Issue Type: Test
> Components: test
> Affects Versions: 1-win
> Environment: Windows
> Reporter: Xi Fang
> Assignee: Xi Fang
> Priority: Minor
> Labels: test
> Attachments: HADOOP-9624.branch-1.patch, HADOOP-9624.patch,
> HADOOP-9624.trunk.patch
>
>
> TestFSMainOperationsLocalFileSystem extends Class FSMainOperationsBaseTest.
> PathFilter FSMainOperationsBaseTest#TEST_X_FILTER checks if a path has "x"
> and "X" in its name.
> {code}
> final private static PathFilter TEST_X_FILTER = new PathFilter() {
> public boolean accept(Path file) {
> if(file.getName().contains("x") || file.toString().contains("X"))
> return true;
> else
> return false;
> {code}
> Some of the test cases construct a path by combining path "TEST_ROOT_DIR"
> with a customized partial path.
> The problem is that once the enlistment root path has "X" in its name,
> "TEST_ROOT_DIR" will also has "X" in its name. The path check will pass even
> if the customized partial path doesn't have "X". However, for this case the
> path filter is supposed to reject this path.
> An easy fix is to change "file.toString().contains("X")" to
> "file.getName().contains("X")". Note that org.apache.hadoop.fs.Path.getName()
> only returns the final component of this path.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
