[ https://issues.apache.org/jira/browse/HADOOP-9637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13687943#comment-13687943 ]
Hudson commented on HADOOP-9637: -------------------------------- Integrated in Hadoop-Hdfs-trunk #1435 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1435/]) HADOOP-9637. Adding Native Fstat for Windows as needed by YARN. Contributed by Chuan Liu. (Revision 1494341) Result = FAILURE cnauroth : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1494341 Files : * /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/nativeio/NativeIO.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/io/nativeio/NativeIO.c * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/winutils/chmod.c * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/winutils/chown.c * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/winutils/include/winutils.h * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/winutils/libwinutils.c * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/winutils/ls.c * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/nativeio/TestNativeIO.java > Adding Native Fstat for Windows as needed by YARN > ------------------------------------------------- > > Key: HADOOP-9637 > URL: https://issues.apache.org/jira/browse/HADOOP-9637 > Project: Hadoop Common > Issue Type: Bug > Affects Versions: 3.0.0, 2.1.0-beta > Reporter: Chuan Liu > Assignee: Chuan Liu > Fix For: 3.0.0, 2.1.0-beta > > Attachments: HADOOP-9637-trunk.2.patch, HADOOP-9637-trunk.3.patch, > HADOOP-9637-trunk.patch > > > In the YARN, nodemanager need to enforce the log file can only be accessed by > the owner. At various places, {{SecureIOUtils.openForRead()}} was called to > enforce this check. We don't have {{NativeIO.Posix.getFstat()}} used by > {{SecureIOUtils.openForRead()}} on Windows, and this make the check fail on > Windows. The YARN unit tests > TestAggregatedLogFormat.testContainerLogsFileAccess and > TestContainerLogsPage.testContainerLogPageAccess fail on Windows because of > this. > The JIRA try to provide a Windows implementation of > {{NativeIO.Posix.getFstat()}}. > TestAggregatedLogFormat.testContainerLogsFileAccess test case fails on > Windows. The test case try to simulate a situation where first log file is > owned by different user (probably symlink) and second one by the user itself. > In this situation, the attempt to try to aggregate the logs should fail with > the error message "Owner ... for path ... did not match expected owner ...". > The check on file owner happens at {{AggregatedLogFormat.write()}} method. > The method calls {{SecureIOUtils.openForRead()}} to read the log files before > writing out to the OutputStream. > {{SecureIOUtils.openForRead()}} use {{NativeIO.Posix.getFstat()}} to get the > file owner and group. We don't have {{NativeIO.Posix.getFstat()}} > implementation on Windows; thus, the failure. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira