[
https://issues.apache.org/jira/browse/HADOOP-9439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13688357#comment-13688357
]
Chris Nauroth commented on HADOOP-9439:
---------------------------------------
{quote}
Do we not allow C99 style declaration in the middle of a function in our JNI
code? I've always liked that better than the original C style of declaring all
at the top.
{quote}
One more thing about this: I think Visual Studio still does not support C99.
In the Windows native code, we're declaring all variables at the top of the
function, and it's a compilation error to put declarations in the middle. With
conditional compilation, we could potentially do C99 in the Linux path and C89
in the Windows path, but this might cause confusion.
This isn't an issue for this patch, but I thought I'd mention it.
> JniBasedUnixGroupsMapping: fix some crash bugs
> ----------------------------------------------
>
> Key: HADOOP-9439
> URL: https://issues.apache.org/jira/browse/HADOOP-9439
> Project: Hadoop Common
> Issue Type: Bug
> Components: native
> Affects Versions: 2.0.4-alpha
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HADOOP-9439.001.patch, HADOOP-9439.003.patch,
> HADOOP-9439.005.patch, HADOOP-9439.006.patch, HADOOP-9439.007.patch,
> HADOOP-9439.008.patch, HDFS-4640.002.patch
>
>
> JniBasedUnixGroupsMapping has some issues.
> * sometimes on error paths variables are freed prior to being initialized
> * re-allocate buffers less frequently (can reuse the same buffer for multiple
> calls to getgrnam)
> * allow non-reentrant functions to be used, to work around client bugs
> * don't throw IOException from JNI functions if the JNI functions do not
> declare this checked exception.
> * don't bail out if only one group name among all the ones associated with a
> user can't be looked up.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
