[ 
https://issues.apache.org/jira/browse/HADOOP-9370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13690731#comment-13690731
 ] 

Colin Patrick McCabe commented on HADOOP-9370:
----------------------------------------------

I already reviewed this as part of HADOOP-8040, and this looks good.  It's good 
that we will now have the ability to test both FC and FS.  Obviously, there are 
a few methods with semantic differences which can't be included in this kind of 
common code, but this will save a lot of code duplication.

+1.

I'll commit this in a day or two if there's no additional comments.
                
> Write FSWrapper class to wrap FileSystem and FileContext for better test 
> coverage
> ---------------------------------------------------------------------------------
>
>                 Key: HADOOP-9370
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9370
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: test
>    Affects Versions: 1.2.0, 3.0.0
>            Reporter: Steve Loughran
>            Assignee: Andrew Wang
>         Attachments: hadoop-9370-1.patch, hadoop-9370-2.patch, 
> hadoop-9370-3.patch, hadoop-9370-4.patch, hadoop-9370-5.patch
>
>
> Take the FileSystem and FileContext from HADOOP-9355 and use it for tests 
> against both FS APIs

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to