[ 
https://issues.apache.org/jira/browse/HADOOP-9416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13698504#comment-13698504
 ] 

Colin Patrick McCabe commented on HADOOP-9416:
----------------------------------------------

Thanks, this looks better.

MAX_PATH_LINKS should go in HdfsConstants.java or a similar file.

If, as the comment explains, FSLinkResolver is "a FileContext-specific class," 
I don't think it makes sense to have FileSystemLinkResolver methods call into 
it.  I think {{qualifySymlinkTarget}} could and should be moved into Path, 
since there is nothing FileContext or FileSystem-specific in that method.
                
> Add new symlink resolution methods to FileSystem and FSLinkResolver
> -------------------------------------------------------------------
>
>                 Key: HADOOP-9416
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9416
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs
>    Affects Versions: 3.0.0
>            Reporter: Andrew Wang
>            Assignee: Andrew Wang
>         Attachments: hadoop-9416-1.patch, hadoop-9416-2.patch, 
> hadoop-9416-3.patch, hadoop-9416-4.patch, hadoop-9416-5.patch, 
> hadoop-9416-6.patch, hadoop-9416-7.patch
>
>
> Add new methods for symlink resolution to FileSystem, and add resolution 
> support for FileSystem to FSLinkResolver.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to