[ 
https://issues.apache.org/jira/browse/HADOOP-9416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Wang updated HADOOP-9416:
--------------------------------

    Attachment: hadoop-9416-8.patch

New patch. Took the liberty of adding @Interface annotations too.

I had a similar thought regarding HdfsConstants, but couldn't find an 
equivalent class in hadoop-common.

As for {{qualifySymlinkTarget}}, I removed the delegating methods that just 
call {{getUri()}} on the AFS/FS since they're trivial. I'd rather have this in 
FSLinkResolver than Path though because it feels weird to have an 
internal-use-only symlink method exposed in a public stable class to end-users.

The javadoc is thus somewhat wrong (FSLinkResolver is not entirely 
FileContext-specific). I could break out an interface, but that might be 
overkill for a constant and a single method.
                
> Add new symlink resolution methods to FileSystem and FSLinkResolver
> -------------------------------------------------------------------
>
>                 Key: HADOOP-9416
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9416
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs
>    Affects Versions: 3.0.0
>            Reporter: Andrew Wang
>            Assignee: Andrew Wang
>         Attachments: hadoop-9416-1.patch, hadoop-9416-2.patch, 
> hadoop-9416-3.patch, hadoop-9416-4.patch, hadoop-9416-5.patch, 
> hadoop-9416-6.patch, hadoop-9416-7.patch, hadoop-9416-8.patch
>
>
> Add new methods for symlink resolution to FileSystem, and add resolution 
> support for FileSystem to FSLinkResolver.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to