[ 
https://issues.apache.org/jira/browse/HADOOP-9699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13699348#comment-13699348
 ] 

Mark Miller commented on HADOOP-9699:
-------------------------------------

bq. I'd prefer hardening the diagnosis string, as it is less of a change.

Sounds fine to me.

The Lucene/Solr tests run with a security manager to ensure tests are well 
behaved. This issue makes debugging more painful. I can work around it when 
running into a problem by simply disabling the security manager, but it seems 
preferable that a std java security manager with fine permissions to operate 
does not cause this. 


                
> org.apache.hadoop.fs.FileUtil#canRead and canWrite should return false on 
> SecurityExceptions.
> ---------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-9699
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9699
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Mark Miller
>            Priority: Minor
>         Attachments: HADOOP-9699.patch
>
>
> Currently, if a security manager denies access on these calls, a 
> SecurityException is thrown rather than returning false.
> This causes ugly behavior in MiniDFSCluster#createPermissionsDiagnosisString 
> for example. If you are running with a security manager, that method can hide 
> root exceptions on you because when it tries to create the permissions 
> string, canRead and canWrite can throw security exceptions - the original 
> exception is lost, and the problem may not be permissions related at all (it 
> wasn't in the case that I ran into this).
> Rather than hardening createPermissionsDiagnosisString, it seems like these 
> methods should just treat SecurityExceptions as lack of access.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to