[ 
https://issues.apache.org/jira/browse/HADOOP-9721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Grover updated HADOOP-9721:
--------------------------------

    Description: 
Tomcat ships with a default logging.properties file that's generic enough to be 
used however we already override it with a custom log file as seen at 
https://github.com/apache/hadoop-common/blob/trunk/hadoop-hdfs-project/hadoop-hdfs-httpfs/pom.xml#L557

This is necessary because we can have the log locations controlled by 
httpfs.log.dir env variable (instead of default catalina.base/logs), control 
the prefix of the log files names, etc.

In any case, this overriding doesn't always happen. In my environment, the 
custom logging.properties file doesn't get overridden. The reason is the 
destination logging.properties file already exists and the maven pom's copy 
command silently fails and doesn't override. If we explicitly delete the 
destination logging.properties file, then the copy command successfully 
completes. You may notice, we do the same thing with server.xml (which doesn't 
have this problem). We explicitly delete the destination file first and then 
copy it over. We should do the same with logging.properties as well.

  was:
Tomcat ships with a default logging.properties file that's generic enough to be 
used however we already override it with a custom log file as seen at 
https://github.com/apache/hadoop-common/blob/trunk/hadoop-hdfs-project/hadoop-hdfs-httpfs/pom.xml#L557

This is necessary because we can have the log locations controlled by 
${httpfs.log.dir} (instead of default ${catalina.base}/logs}, control the 
prefix of the log files names, etc.

In any case, this overriding doesn't always happen. In my environment, the 
custom logging.properties file doesn't get overridden. The reason is the 
destination logging.properties file already exists and the maven pom's copy 
command silently fails and doesn't override. If we explicitly delete the 
destination logging.properties file, then the copy command successfully 
completes. You may notice, we do the same thing with server.xml (which doesn't 
have this problem). We explicitly delete the destination file first and then 
copy it over. We should do the same with logging.properties as well.

    
> Incorrect logging.properties file for hadoop-httpfs
> ---------------------------------------------------
>
>                 Key: HADOOP-9721
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9721
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build, conf
>    Affects Versions: 2.0.4-alpha
>         Environment: Maven 3.0.2 on CentOS6.2
>            Reporter: Mark Grover
>
> Tomcat ships with a default logging.properties file that's generic enough to 
> be used however we already override it with a custom log file as seen at 
> https://github.com/apache/hadoop-common/blob/trunk/hadoop-hdfs-project/hadoop-hdfs-httpfs/pom.xml#L557
> This is necessary because we can have the log locations controlled by 
> httpfs.log.dir env variable (instead of default catalina.base/logs), control 
> the prefix of the log files names, etc.
> In any case, this overriding doesn't always happen. In my environment, the 
> custom logging.properties file doesn't get overridden. The reason is the 
> destination logging.properties file already exists and the maven pom's copy 
> command silently fails and doesn't override. If we explicitly delete the 
> destination logging.properties file, then the copy command successfully 
> completes. You may notice, we do the same thing with server.xml (which 
> doesn't have this problem). We explicitly delete the destination file first 
> and then copy it over. We should do the same with logging.properties as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to